Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyprctl: add modkeys to binds command #8607

Closed
wants to merge 2 commits into from
Closed

hyprctl: add modkeys to binds command #8607

wants to merge 2 commits into from

Conversation

davc0n
Copy link
Contributor

@davc0n davc0n commented Nov 28, 2024

Describe your PR, what does it fix/add?

#8606

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

No

Is it ready for merging, or does it need work?

Ready

vaxerski
vaxerski reviewed Nov 30, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that just duplicating info

@davc0n
Copy link
Contributor Author

davc0n commented Nov 30, 2024

Not sure, that's the current output:

binde
	modmask: 65
	submap: 
	key: l
	keycode: 0
	catchall: false
	description: 
	dispatcher: moveactive
	arg: 20 0

There would be an additional line: modkeys: SUPER SHIFT
This information is not directly available.

Or do you mean it should be computed on the fly, rather than stored in SKeybind ?

@vaxerski
Copy link
Member

vaxerski commented Dec 2, 2024

This information is not directly available

it is. See modmask.

@davc0n
Copy link
Contributor Author

davc0n commented Dec 2, 2024

With direct I meant explicit.
Must remember which keys belongs to the given code.

Anyway if you believe that's useless just close this PR and the related issue as not planned.

@vaxerski
Copy link
Member

vaxerski commented Dec 3, 2024

Must remember which keys belongs to the given code.

it's constant, it doesn't change.

Anyways, as suggested.

@vaxerski vaxerski closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski left review comments

Assignees
No one assigned
Labels
config core debug managers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davc0n @vaxerski